make c_s_max an input to functions #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosaplanella
approved these changes
Jun 29, 2022
| @@ -1,7 +1,9 @@ | |||
| from pybamm import exp, constants, Parameter | |||
|
|
|||
|
|
|||
| def graphite_LGM50_electrolyte_exchange_current_density_ORegan2021(c_e, c_s_surf, T): | |||
| def graphite_LGM50_electrolyte_exchange_current_density_ORegan2021( | |||
| c_e, c_s_surf, T, c_s_max | |||
There was a problem hiding this comment.
Very picky comment (and maybe quite annoying to implement). Do we want to flip T and c_s_max? This way we have electrochemical variables first, and temperature last.
There was a problem hiding this comment.
sure, not too hard to change
Codecov Report
@@ Coverage Diff @@
## develop #2134 +/- ##
===========================================
- Coverage 99.38% 99.38% -0.01%
===========================================
Files 355 355
Lines 19302 19279 -23
===========================================
- Hits 19183 19160 -23
Misses 119 119
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
c_s_maxas an input to some functions, instead of defining it as a parameter inside the function.This is an attempt to split up #2073
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: